Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Prepare Trappist v1.1.0 release #308

Merged
merged 9 commits into from
Nov 24, 2023
Merged

Prepare Trappist v1.1.0 release #308

merged 9 commits into from
Nov 24, 2023

Conversation

stiiifff
Copy link
Contributor

No description provided.

@stiiifff
Copy link
Contributor Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Oct 31, 2023

@stiiifff https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4153939 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-5401b6b6-e75c-4710-bf5f-eecf7ff96d1a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 31, 2023

@stiiifff Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4153939 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4153939/artifacts/download.

@stiiifff
Copy link
Contributor Author

stiiifff commented Nov 5, 2023

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Nov 5, 2023

@stiiifff https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4218217 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 27-b2f59cbe-ad52-4cac-9844-a0d8e818eb6e to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 5, 2023

@stiiifff Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4218217 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4218217/artifacts/download.

@metricaez
Copy link
Collaborator

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Nov 21, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4419815 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 71-a101f32c-edc1-4dc3-99e2-16c3f9bda507 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 21, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4419815 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4419815/artifacts/download.

@stiiifff
Copy link
Contributor Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Nov 22, 2023

@stiiifff https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4431703 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-00a88e7a-2b63-444b-be5a-93ba80078b0b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 22, 2023

@stiiifff Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4431703 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4431703/artifacts/download.

@pgherveou
Copy link

You need to set type MaxHolds on pallet_balances Config to some non 0 value here, or pallet_contracts fails to hold some balance for uploading new contracts, and you end up with the error StorageDepositNotEnoughFunds from the jobs log.

Will add some more warn in the pallet_contracts logs to make this more obvious!

@metricaez
Copy link
Collaborator

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Nov 23, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4450187 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-c2b467a7-3f12-4df8-b585-bf80e38c6086 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 23, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4450187 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4450187/artifacts/download.

@stiiifff stiiifff added the migration This pull request has a storage migration label Nov 23, 2023
@stiiifff
Copy link
Contributor Author

Ignoring the try-runtime check error, as there's effectively is no runtime migration in this release.

@Moliholy
Copy link
Contributor

Moliholy commented Nov 23, 2023

Ignoring the try-runtime check error, as there's effectively is no runtime migration in this release.

I just run the migration and it turns out pallet-contracts is at version 12 instead of 15. That's, as you've mentioned, not supposed to be that way, because trappist was migrated in the past to version 15. However, try-runtime says otherwise. I think it'd be wise to further research this issue.

Furthermore, when running try-runtime with the try-state flag, I discovered there's data corruption in pallet-collective. An extra migration would be needed to solve this issue.

You can check the above by running the following command:

try-runtime --runtime ./target/release/wbuild/trappist-runtime/target/wasm32-unknown-unknown/release/trappist_runtime.wasm \
              on-runtime-upgrade --checks pre-and-post --disable-idempotency-checks live --uri wss://rococo-trappist-try-runtime-node.parity-chains.parity.io:443

@metricaez
Copy link
Collaborator

Ignoring try-runtime error as it is non breaking while we debug it.

metricaez
metricaez previously approved these changes Nov 23, 2023
@metricaez
Copy link
Collaborator

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Nov 23, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4458156 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-18cae4ae-7527-4f9a-ba0e-6299d18699c7 to cancel this command or bot cancel to cancel all commands in this pull request.

metricaez
metricaez previously approved these changes Nov 23, 2023
@command-bot
Copy link

command-bot bot commented Nov 23, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4458156 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4458156/artifacts/download.

@metricaez metricaez self-requested a review November 23, 2023 21:45
@stiiifff stiiifff merged commit 677ba01 into main Nov 24, 2023
6 checks passed
@stiiifff stiiifff deleted the sde-prepare-v11000-release branch November 24, 2023 21:29
@stiiifff
Copy link
Contributor Author

LGTM !

@metricaez metricaez restored the sde-prepare-v11000-release branch December 26, 2023 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migration This pull request has a storage migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants