-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on-runtime-upgrade
should enforce migrations are idempotent
#42
Labels
enhancement
New feature or request
Comments
liamaharon
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Oct 17, 2023
liamaharon
added a commit
to paritytech/polkadot-sdk
that referenced
this issue
Oct 30, 2023
Runtime migration CI is currently failing (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/4122083) for the contracts testnet due to unnecessary panicing in a `pre_upgrade` hook. Soon idempotency will be enforced paritytech/try-runtime-cli#42, in the mean time we need to manually fix these issues as they arise. --- also removes backticks from the string in `echo`, which caused a 'command not found' error in ci output
liamaharon
added a commit
that referenced
this issue
Nov 10, 2023
Closes #42 Checks that `on_runtime_upgrade` succeeds when called twice, and if it does succeed after being called twice, the storage state root did not change. --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this issue
Mar 25, 2024
Runtime migration CI is currently failing (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/4122083) for the contracts testnet due to unnecessary panicing in a `pre_upgrade` hook. Soon idempotency will be enforced paritytech/try-runtime-cli#42, in the mean time we need to manually fix these issues as they arise. --- also removes backticks from the string in `echo`, which caused a 'command not found' error in ci output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See paritytech/polkadot-sdk#1921 (comment)
Should enforce by default, and allow skipping by specifying a CLI flag.
The text was updated successfully, but these errors were encountered: