Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error generating compact proof #76

Closed
liamaharon opened this issue Jan 25, 2024 · 1 comment · Fixed by #77
Closed

Error generating compact proof #76

liamaharon opened this issue Jan 25, 2024 · 1 comment · Fixed by #77
Assignees
@liamaharon
Labels
bug Something isn't working

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Jan 25, 2024 •
edited
Loading

Reported here https://substrate.stackexchange.com/questions/10351/try-runtime-failed-to-generate-compact-proof-trieerrorinvalidstateroot and also impacts Asset Hub Kusama main branch.

Calling into https://github.com/paritytech/polkadot-sdk/blob/4ca193f88b55dc9b12d7a586113f9db192e1bdd8/substrate/primitives/trie/src/storage_proof.rs#L103 when calculating the PoV can return an error when the runtime differs in a particular way relative to the runtime the snapshot was generated from.

To debug, can bisect the Fellowship Runtime repo commit history starting from v1.0.1 to see exactly which change caused this issue.
@liamaharon liamaharon added the bug Something isn't working label Jan 25, 2024
@liamaharon liamaharon self-assigned this Jan 25, 2024
@liamaharon liamaharon changed the title Sometimes error generating compact proof Error generating compact proof Jan 25, 2024
@liamaharon liamaharon mentioned this issue Jan 29, 2024
Merged
@liamaharon
Copy link
Contributor Author

Simply an error when the PoV is empty e.g. due to Migrations tuple being empty.

liamaharon added a commit that referenced this issue Jan 29, 2024
@liamaharon
Fix TrieError(InvalidStateRoot(...)) error log when runtime upgrade…
7abe31b 
… PoV is empty (#77)

Closes #76
@Ad96el Ad96el mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamaharon liamaharon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@liamaharon