Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

move to rust 2021 #173

Merged
merged 3 commits into from
Nov 21, 2021
Merged

move to rust 2021 #173

merged 3 commits into from
Nov 21, 2021

Conversation

nuke-web3
Copy link
Contributor

No description provided.

@nuke-web3 nuke-web3 requested a review from athei November 14, 2021 02:59
@nuke-web3
Copy link
Contributor Author

MSRV is The "minimum supported Rust version" right?

"increments are a breaking Semver change" policy may applies to this repository 🤔 should it?

The relevant check should update to the minimal dependency versions first, in order to make sure newer compatible versions are ignored in this regard.

AFAIK minimal stable toolchain version with rust edition 2021 is rustc 1.56.0
https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html

This could be propagated in all change logs and maybe include a version bump. But what type? patch, minor or major?
Or no bump?

@athei
Copy link
Member

athei commented Nov 15, 2021

paritytech/parity-wasm#322 (comment)

edition = "2021"
rust-version = "1.56.1"
@nuke-web3
Copy link
Contributor Author

rust-version = "1.56.1" introduced

For reference, I tried to get this to cargo build with 1.56.0 and it failed with

error: package `...` cannot be built because it requires rustc 1.56.1 or newer, while the currently active rustc version is 1.56.0

With --ignore-rust-version it does build with 1.56.0, as expected.

@nuke-web3 nuke-web3 requested a review from athei November 21, 2021 06:46
@nuke-web3 nuke-web3 merged commit 5259f1c into master Nov 21, 2021
@athei athei deleted the NukeManDan-patch-1 branch November 22, 2021 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants