Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs/book files with new mdbook version #1503

Conversation

Neyromancer
Copy link
Contributor

@Neyromancer Neyromancer commented Nov 9, 2023

Descritption

Update docs/book HTML files with new version of mdbook.
mdbook v0.4.35

Relates to PR #1439 and issue #1412

This PR should be as a preparation for PR #1439 which make changes to doc files.

@pepoviola
Copy link
Collaborator

Thanks for your contribution @Neyromancer! but let me ping @wirednkod to correct me if I'm wrong, but I think the html files of docs/book are auto-generated by a workflow in GHA. We should no manually change those, if need to update the mdBook version we should update the workflow
Thx!

@pepoviola pepoviola added the question Further information is requested label Nov 9, 2023
@Neyromancer
Copy link
Contributor Author

Neyromancer commented Nov 10, 2023

Thanks for your contribution @Neyromancer! but let me ping @wirednkod to correct me if I'm wrong, but I think the html files of docs/book are auto-generated by a workflow in GHA. We should no manually change those, if need to update the mdBook version we should update the workflow Thx!

@pepoviola, thank you for your reply. It looks as if it is indeed should be updated there. I did not check CI scripts, pardon

@wirednkod
Copy link
Contributor

Thanks for your contribution @Neyromancer! but let me ping @wirednkod to correct me if I'm wrong, but I think the html files of docs/book are auto-generated by a workflow in GHA. We should no manually change those, if need to update the mdBook version we should update the workflow Thx!

That is correct. The changed files will though be overwritten and since same changes applied everywhere then, the final doc files will be correct

@wirednkod
Copy link
Contributor

wirednkod commented Nov 10, 2023

Thank you so much for the contributions @Neyromancer . I will be closing this as it does not make sense to update the files that willbe overridden

@wirednkod wirednkod closed this Nov 10, 2023
@pepoviola
Copy link
Collaborator

Hi @Neyromancer thanks for your contribution!! We just closed this one since as we said before we should not change html files directly since those are generated again from GHA.
Thanks again!

@Neyromancer Neyromancer deleted the Update_html_docs_from_current_mdbook_version branch November 10, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants