Merge pull request #167 from parkpow/danleyb2-patch-1

Disable code signing windows installer
parkpow · Dec 26, 2023 · 5c62876 · 5c62876
2 parents 93f307c + 1c2079c
commit 5c62876
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 34 deletions.
diff --git a/.github/workflows/installers.yml b/.github/workflows/installers.yml
@@ -34,29 +34,28 @@ jobs:
         name: PlateRecognizer-Installer-Linux
         path: docker/dist/PlateRecognizer-Installer
 
-  sign-installer:
-    name: Sign
-    runs-on: windows-latest
-    needs: windows-installer
-    steps:
-      - uses: actions/download-artifact@v2
-        with:
-          name: Windows-Installer-unsigned
-          path: dist
-
-      - uses: DanaBear/code-sign-action@98c79121b376beab8d6a9484f445089db4461bca
-        with:
-          certificate: '${{ secrets.CERTIFICATE }}'
-          password: '${{ secrets.PASSWORD }}'
-          certificatesha1: '${{ secrets.CERTIFICATE_SHA1 }}'
-          timestampUrl: '${{ secrets.TIMESTAMP_URL }}'
-          folder: dist
-          recursive: true
+  # sign-installer:
+  #   name: Sign
+  #   runs-on: windows-latest
+  #   needs: windows-installer
+  #   steps:
+  #     - uses: actions/download-artifact@v2
+  #       with:
+  #         name: Windows-Installer-unsigned
+  #         path: dist
 
-      - uses: actions/upload-artifact@v2
-        with:
-          name: PlateRecognizer-Installer-Windows
-          path: dist
+  #     - uses: DanaBear/code-sign-action@98c79121b376beab8d6a9484f445089db4461bca
+  #       with:
+  #         certificate: '${{ secrets.CERTIFICATE }}'
+  #         password: '${{ secrets.PASSWORD }}'
+  #         certificatesha1: '${{ secrets.CERTIFICATE_SHA1 }}'
+  #         timestampUrl: '${{ secrets.TIMESTAMP_URL }}'
+  #         folder: dist
+  #         recursive: true
+  #     - uses: actions/upload-artifact@v2
+  #       with:
+  #         name: PlateRecognizer-Installer-Windows
+  #         path: dist
 
   mac-installer:
     runs-on: macos-latest

diff --git a/docker/build.md b/docker/build.md
@@ -68,15 +68,5 @@ Chdir into the `docker` folder and run this command:
 
 This will generate the EXE in the following path **deep-license-plate-recognition\docker\dist**
 
-## 7. Sign the EXE with CA certificate
-The signtool is installed when you install the Build tools.
-
-Assumming the following enviroment:
-- The CA Certificate is located in this path: "C:\Users\hp\Downloads\PRPP-Cert-022621.pfx"
-- The CA Certificate password is: Uxz#######
-- The Output EXE from the previous step is located in this path: "C:\Users\hp\Downloads\PlateRecognizer-Installer.exe"
-
-Run this command to sign the EXE:
-```
-C:\Program Files (x86)\Windows Kits\10\App Certification Kit>signtool.exe sign /debug /f "C:\Users\hp\Downloads\PRPP-Cert-022621.pfx" /p Uxz####### "C:\Users\hp\Downloads\PlateRecognizer-Installer.exe"
-```
+## 7. Code Sign the EXE
+Check [this Google doc](https://docs.google.com/document/d/12Bvc7LffTOmJNTWMdGWaDxHAeL37ukvWBNSTQu6ZgLM/edit?usp=sharing) for instructions.