-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-error-usernameNXintegration #187
Conversation
Risk Level 2 - /home/runner/work/deep-license-plate-recognition/deep-license-plate-recognition/webhooks/Webhook_nx/main.py The changes include the addition of command-line arguments for login credentials and environment variable handling. The risk is moderate due to the potential exposure of sensitive information if not handled properly. However, there are no API keys or secrets directly exposed in the code changes.
Example for boolean argument parsing: parser.add_argument(\"--ssl\", action='store_true', help=\"Enable SSL verification\")
🔒🐛👀 Powered by Code Review GPT |
@adolfoarmas FYI |
@ttayson just curious, what value did you receive when "username" argument name was used? what a strange situation. If it works now, LGTM! |
Co-authored-by: Adolfo Armas <adolfoarmas.90@gmail.com>
@adolfoarmas, in my case, I received "Talles Tayson" as the username from the login. This happens because I use environment variables to capture the value when the user is using Docker, perhaps there is a better way to do this |
@ttayson i see, there it is: https://adolfo-platerecognizer.tinytake.com/msc/OTM1NzU5OF8yMjkyNTQ1NQ FYI https://docs.python.org/3/library/os.html#os.getenvb
LGTM |
Note: Sorry for the typo in the branch name.
For some reason, when using a username argument on Windows, the user account name is captured, interfering with the information passed to the script.