-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward Verkada LPR Webhooks to ParkPow Visits #197
Conversation
Risk Level 3 - /home/runner/work/deep-license-plate-recognition/deep-license-plate-recognition/parkpow/webhook-verkada/main.py The code changes introduce several new features and classes, which increases the complexity of the system. There are a few areas that could be improved for better error handling, code readability, and maintainability:
Here's an example of how to define a constant for retries: MAX_RETRIES = 5
# ... later in the code ...
while tries < MAX_RETRIES:
# ... retry logic ... And an example of improved exception handling in except requests.RequestException as e:
error_message = f\"Error logging vehicle: {response.text}\"
lgr.error(error_message, exc_info=e)
raise Exception(error_message) 🔍🛠️🚦 Powered by Code Review GPT |
@danleyb2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @adolfoarmas recommendations are also nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://trello.com/c/7FsGpiYS/1624-integration-verkada