-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit of docker desktop extension #218
Conversation
Risk Level 3 - /home/runner/work/deep-license-plate-recognition/deep-license-plate-recognition/docker/dd-extension/ui/src/components/Stream.tsx Similar to the Risk Level 3 - /home/runner/work/deep-license-plate-recognition/deep-license-plate-recognition/docker/dd-extension/ui/src/components/Snapshot.tsx The Risk Level 4 - /home/runner/work/deep-license-plate-recognition/deep-license-plate-recognition/docker/dd-extension/backend/utils.py The 🔒🐛🚨 Powered by Code Review GPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, good stuff.
- Some of the URLs need updating (marked).
- For snapshot, we need two dropdowns, one for country, one for architecture (commented).
More globally, I see a lot of small issues with the TSX code, would you mind adding eslint and fixing the errors?
I think it would make the code cleaner and more maintainable:
- cd ..../ui
npm init @eslint/config@latest
- check syntax and find problems
- js modules
- react
- yes for typescript
- node
- yes to install
- Install the VSCode
eslint
extension.
The generated config should look like this:
import globals from "globals";
import pluginJs from "@eslint/js";
import tseslint from "typescript-eslint";
import pluginReact from "eslint-plugin-react";
export default [
{files: ["**/*.{js,mjs,cjs,ts,jsx,tsx}"]},
{languageOptions: { globals: globals.browser }},
pluginJs.configs.recommended,
...tseslint.configs.recommended,
pluginReact.configs.flat.recommended,
];
Don't hesitate to ping me if you need!
@Pefington added eslint however some the lint errors such as |
Thank you, I'll check in the morning. |
@Pefington This bot is autodated and got recently replaced with coderabbit. Let's ignore it. I'll try run coderabbit |
Co-authored-by: Pierre-François Salmand <71193709+Pefington@users.noreply.github.com>
Co-authored-by: Pierre-François Salmand <71193709+Pefington@users.noreply.github.com>
Co-authored-by: Pierre-François Salmand <71193709+Pefington@users.noreply.github.com>
Co-authored-by: Pierre-François Salmand <71193709+Pefington@users.noreply.github.com>
Co-authored-by: Pierre-François Salmand <71193709+Pefington@users.noreply.github.com>
a88d732
to
e6cb426
Compare
## Walkthrough
This initial commit introduces a Docker Desktop extension featuring a React frontend and a Python backend. It includes configuration files, a Dockerfile for multi-stage builds, a Makefile for managing the extension lifecycle, and essential application code for both frontend and backend components.
## Changes
| Files | Summary |
|--------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `.gitignore`, `.vscode/settings.json` | Adds ignore rules for build artifacts and configures VSCode settings for Makefile behavior. |
| `Dockerfile`, `Makefile`, `README.md` | Introduces Dockerfile for building the extension, a Makefile for managing tasks, and documentation for setup and usage. |
| `backend/main.py`, `backend/utils.py` | Implements a Flask app with token verification logic and utility functions for API requests. |
| `backend/requirements.txt`, `backend/wsgi.py` | Specifies Python dependencies and sets up WSGI entry point for the backend application. |
| `ui/eslint.config.js`, `ui/index.html` | Configures ESLint for the UI and provides an HTML template for the React app. |
| `ui/src/App.tsx`, `ui/src/components/Loader.tsx` | Introduces React components for the main application interface and a loader component. |
> In Docker's realm, a new tale unfolds,
> With Node and Python, brave and bold.
> A frontend dances in React's embrace,
> While Flask ensures the backend's grace.
> Together they sail on Docker's stream,
> A coder's dream, a rabbit's gleam. 🐇🚀 Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (22)
- docker/dd-extension/.gitignore (1)
- docker/dd-extension/.vscode/settings.json (1)
- docker/dd-extension/Dockerfile (1)
- docker/dd-extension/Makefile (1)
- docker/dd-extension/README.md (1)
- docker/dd-extension/backend/main.py (1)
- docker/dd-extension/backend/requirements.txt (1)
- docker/dd-extension/backend/utils.py (1)
- docker/dd-extension/backend/wsgi.py (1)
- docker/dd-extension/ui/eslint.config.js (1)
- docker/dd-extension/ui/index.html (1)
- docker/dd-extension/ui/src/App.tsx (1)
- docker/dd-extension/ui/src/components/Loader.tsx (1)
- docker/dd-extension/ui/src/components/ShowCommand.tsx (1)
- docker/dd-extension/ui/src/components/Snapshot.tsx (1)
- docker/dd-extension/ui/src/components/Stream.tsx (1)
- docker/dd-extension/ui/src/components/Uninstall.tsx (1)
- docker/dd-extension/ui/src/components/Update.tsx (1)
- docker/dd-extension/ui/src/helpers.ts (1)
- docker/dd-extension/ui/src/hooks/useDockerDesktopClient.ts (1)
- docker/dd-extension/ui/src/main.tsx (1)
- docker/dd-extension/ui/vite.config.ts (1)
Files ignored due to filter (7)
- docker/dd-extension/docker-compose.yaml
- docker/dd-extension/logo.svg
- docker/dd-extension/metadata.json
- docker/dd-extension/ui/package-lock.json
- docker/dd-extension/ui/package.json
- docker/dd-extension/ui/tsconfig.json
- docker/dd-extension/ui/tsconfig.node.json
Files skipped from review due to trivial changes (4)
- docker/dd-extension/.gitignore
- docker/dd-extension/backend/wsgi.py
- docker/dd-extension/ui/src/components/Snapshot.tsx (diff too large)
- docker/dd-extension/ui/src/components/Stream.tsx (diff too large)
Review comments generated (23)
- Review: 13
- LGTM: 10
Tips
Chat with CodeRabbit Bot (@coderabbitai
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitai
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignore
anywhere in the PR description to pause further reviews from the bot.
@danleyb2 Thank you, the changes are good, everything works. |
@Pefington I'll resolve a number then merge |
Summary by CodeRabbit
/verify-token
endpoint in the Flask application for token verification..gitignore
to exclude unnecessary files from version control.