Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup old duplicate middlewares #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AashishDhakal
Copy link
Collaborator

@AashishDhakal AashishDhakal commented Oct 26, 2024

Summary by CodeRabbit

  • Chore: Removed multiple Dockerfiles and associated Python scripts for webhooks, including Synology, OpenEye, NX, and Salient integrations. This cleanup includes middleware handling, server configuration, and API interaction logic.
  • Documentation: Deleted README files containing setup and configuration instructions for various webhook integrations.
  • Chore: Removed dependencies from requirements.txt files across several webhook projects, potentially affecting any remaining code that relied on these packages.

Copy link

github-actions bot commented Oct 26, 2024

Image description CodeRabbit

## Walkthrough
The changes involve the complete removal of several Dockerfiles, Python scripts, and requirements files related to various webhook services. These deletions indicate a significant refactoring or deprecation of these components, potentially simplifying the codebase by removing unused or outdated functionality.

## Changes

| Files                                                                 | Summary                                                                                                                                                                                                 |
|-----------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `webhooks/Synology/Dockerfile`, `webhooks/Webhook_OpenEye/Dockerfile`, `webhooks/Webhook_nx/Dockerfile`, `webhooks/webhook_salient/Dockerfile` | Removal of Dockerfiles used for building Python applications, including environment setup and dependency installation.                                           |
| `webhooks/Synology/middleware_webhook_rest.py`, `webhooks/Webhook_OpenEye/main.py`, `webhooks/Webhook_nx/main.py`, `webhooks/webhook_crop_plate_and_forward/webhook_crop_plate_middleware.py` | Complete removal of Python scripts acting as middleware or webhook servers handling HTTP requests and interacting with external APIs.                             |
| `webhooks/Synology/requirements.txt`, `webhooks/Webhook_OpenEye/requirements.txt`, `webhooks/Webhook_nx/requirements.txt` | Removal of Python package dependencies from requirements files, affecting any code relying on these packages.                                                     |
| `webhooks/Webhook_OpenEye/README.md`, `webhooks/Webhook_nx/README.md` | Deletion of README files containing setup instructions and configuration details for webhooks and integrations with external systems.                              |

> In the realm of code, where logic once danced,  
> A cleanup ensues, a chance to enhance.  
> With Dockerfiles gone and scripts set free,  
> The codebase breathes with simplicity. 🌟  
> As rabbits we hop through fields of change,  
> Embracing the new, though it feels strange. 🐇✨  

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 39eb3e9 and 937902f commits.
Files selected (16)
  • webhooks/Synology/Dockerfile (1)
  • webhooks/Synology/middleware_webhook_rest.py (1)
  • webhooks/Synology/requirements.txt (1)
  • webhooks/Webhook_OpenEye/Dockerfile (1)
  • webhooks/Webhook_OpenEye/README.md (1)
  • webhooks/Webhook_OpenEye/main.py (1)
  • webhooks/Webhook_OpenEye/requirements.txt (1)
  • webhooks/Webhook_nx/Dockerfile (1)
  • webhooks/Webhook_nx/README.md (1)
  • webhooks/Webhook_nx/main.py (1)
  • webhooks/Webhook_nx/requirements.txt (1)
  • webhooks/webhook_crop_plate_and_forward/webhook_crop_plate_middleware.py (1)
  • webhooks/webhook_salient/Dockerfile (1)
  • webhooks/webhook_salient/README.md (1)
  • webhooks/webhook_salient/main.py (1)
  • webhooks/webhook_soap/middleware_webhook_soap.py (1)
Files skipped from review due to trivial changes (5)
  • webhooks/Webhook_OpenEye/README.md
  • webhooks/Webhook_OpenEye/main.py
  • webhooks/Webhook_nx/README.md
  • webhooks/webhook_crop_plate_and_forward/webhook_crop_plate_middleware.py
  • webhooks/webhook_soap/middleware_webhook_soap.py
Review comments generated (4)
  • Review: 0
  • LGTM: 4

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant