Catch exceptions from implementations of ProjectItem #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenFileInSolution throws an exception for me in solutions with a Wix project type, and the window never displays.
The root cause of this seems to be Wix not properly implementing ProjectItem, since
.Kind
should return a GUID.Since this exception is thrown in a getter, I couldn't think of any way to avoid it throwing so it is wrapped in a try/catch. There was no noticeable performance impact.
The exception is thrown in multiple Wix project types, so it would get a messy if we tried to maintain an ignore list. It's also likely other custom project types could throw this exception so even though Wix is at fault, I believe OpenFileInSolution benefits from this change. Looking forward to hearing what you think though.
I also added the description info and screenshot to the readme (which you OK'ed in my last PR). This project needs to be appreciated, it's critical for my workflow because it is so much faster than built-in VS search! Thanks again.