Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions from implementations of ProjectItem #4

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Catch exceptions from implementations of ProjectItem #4

merged 2 commits into from
Apr 4, 2018

Conversation

fotijr
Copy link
Contributor

@fotijr fotijr commented Apr 4, 2018

OpenFileInSolution throws an exception for me in solutions with a Wix project type, and the window never displays.

Member not found exception

The root cause of this seems to be Wix not properly implementing ProjectItem, since .Kind should return a GUID.
Wix ProjectItem properties

Since this exception is thrown in a getter, I couldn't think of any way to avoid it throwing so it is wrapped in a try/catch. There was no noticeable performance impact.

The exception is thrown in multiple Wix project types, so it would get a messy if we tried to maintain an ignore list. It's also likely other custom project types could throw this exception so even though Wix is at fault, I believe OpenFileInSolution benefits from this change. Looking forward to hearing what you think though.

I also added the description info and screenshot to the readme (which you OK'ed in my last PR). This project needs to be appreciated, it's critical for my workflow because it is so much faster than built-in VS search! Thanks again.

@fotijr
Copy link
Contributor Author

fotijr commented Apr 4, 2018

Also, could a new version of this be pushed to the marketplace? There have been a few nice improvements since the last published extension version (published 8/30/17).

@parnic parnic merged commit 7919800 into parnic:master Apr 4, 2018
@parnic
Copy link
Owner

parnic commented Apr 4, 2018

Thanks for the contributions! I haven't had as much time to work on this lately as I'd like.

I'll try to get a new build pushed to the marketplace soon.

@fotijr
Copy link
Contributor Author

fotijr commented Apr 4, 2018

@parnic thank you!

And as an aside, I was able to find an open issue from 5 years ago in the Wix repo so added info there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants