Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple files with the same name. #5

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

akb825
Copy link
Contributor

@akb825 akb825 commented Apr 6, 2018

When multiple files with the same filename, but different path, appear
in the same solution, all files will be displayed. Duplicates of the
same file path will still be removed.

e.g. C:\Foo\Bar.h and C:\Baz\Bar.h will both be shown. However, if
C:\Foo\Bar.h is referenced twice it will only be shown once.

When multiple files with the same filename, but different path, appear
in the same solution, all files will be displayed. Duplicates of the
same file path will still be removed.

e.g. C:\Foo\Bar.h and C:\Baz\Bar.h will both be shown. However, if
C:\Foo\Bar.h is referenced twice it will only be shown once.
@akb825
Copy link
Contributor Author

akb825 commented Apr 6, 2018

Sorry, I missed that the filename was being checked to remove duplicate items when adding the grid view. Now that Filename is just the filename portion rather than the full path, it caused files with the same name but different paths to be dropped.

@parnic parnic merged commit 5a3ab3d into parnic:master Apr 6, 2018
@parnic
Copy link
Owner

parnic commented Apr 6, 2018

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants