-
Notifications
You must be signed in to change notification settings - Fork 26
Introduce checkstyle to enforce conventions #326
Introduce checkstyle to enforce conventions #326
Conversation
This PR is going to heavily fail since our code base doesn't entirely match the convention of spring. |
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
nor System.out.println Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirarg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@masayag may I suggest updating the |
@gciavarrini as the name and the action suggests - |
What this PR does / why we need it:
We'd like to make sure our code base is aligned with its conventions.
Which issue(s) this PR fixes :
Fixes #FLPATH-347
Change type
Impacted services
Checklist