Take the highest coverage count for a single line #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the call to erlang's cover.analyse/3 will return more than one result for the same line. Usually the coverage count is the same, but in some cases (e.g. with schema definitions in an Ecto model) the coverage count can alternate between different values, like 1 and 0, and the line might be marked as covered or not depending on the order of these results. Investigations did not lead to a definite answer as to why this is happening, but with this fix we will at least take the greatest coverage count, instead of the latest, as the value for our report. Fixes parroty#84
Kjir
force-pushed
the
fix/coverage_changes
branch
from
e6eace9
to
8dbe15d
Compare
|
Thanks for addressing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the call to erlang's cover.analyse/3 will return more than
one result for the same line. Usually the coverage count is the same,
but in some cases (e.g. with schema definitions in an Ecto model) the
coverage count can alternate between different values, like 1 and 0, and
the line might be marked as covered or not depending on the order of
these results.
Investigations did not lead to a definite answer as to why this is
happening, but with this fix we will at least take the greatest coverage
count, instead of the latest, as the value for our report.
Fixes #84