Changes the behavior of mix coveralls.post so that it recognizes #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that coverage is being run against an umbrella app and only posts to coveralls.io once all sub-applications have been analysed
|
@parroty Any concerns around this PR? |
|
Thanks, great! and sorry being late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that coverage is being run against an umbrella app and only posts
to coveralls.io once all sub-applications have been analysed
Fixes #76
Prior to this change,
Poster.execute/2was getting called after every sub application's coverage was calculated. Now, it only gets called once at the end of the last sub application's coverage run.The excoveralls.post.json file that is sent to coveralls.io contains all of the files from all sub-applications and the reported coverage number in coveralls.io now matches that produced in the summary line when running:
mix coveralls --umbrella