merge dot file settings and project settings #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… homedir, this dotfile config will be the base config which can be extended by the project config.
|
Sorry, I was a bit to quick with testing :/ It seems there are still some edge cases to cover. Please wait for this... |
|
It's now working as intended, sorry for the slipup ! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So I'm using the dot file settings quite a lot to customise the report template and to add some global ignores. Working with other projects I found that it would be very useful if the coveralls.json defined in the project would merge its settings with those of the users dot file one. This way the project defined one always overrules the dot file one if duplicate keys are defined.
I've also updated the test to accommodate for the custom dot file. my previous patch worked as long as you had no dot file while running the tests. its now integrated with the other mocks.
Please let me know if you agree with this, and if the purpose is clear :)
Gerard