Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLCov style reports #40

Merged
merged 1 commit into from
Feb 20, 2016
Merged

Conversation

erikreedstrom
Copy link
Contributor

  • added task for html report generation
  • tests added for report generation
  • updated mock lib to allow for context in mocked tests

@erikreedstrom erikreedstrom force-pushed the html_report branch 3 times, most recently from b610130 to 93b0963 Compare February 2, 2016 00:58
@parroty
Copy link
Owner

parroty commented Feb 3, 2016

Thanks, please allow me some time to review, as its relatively large one. It might be on weekend.

@erikreedstrom
Copy link
Contributor Author

No worries. There's likely room for improvement. Open for suggestions.

@parroty
Copy link
Owner

parroty commented Feb 7, 2016

Sorry taking time, I'm just trying out.
It's working great and the design seems quite nice too! Is there any base templates?

Some feedbacks are,

  • How about having color on covered lines? (ex. green color). I can see line counts, but maybe good to have easier indicator to differentiate them from irrelevant lines.
  • It's minor ones, but it seems some warnings are emitted (following).
lib/excoveralls/html.ex:135: warning: function print_string/2 is unused
...
lib/excoveralls/html.ex:6: warning: unused alias Local

@erikreedstrom
Copy link
Contributor Author

Thanks for the feedback!

There is only this template currently, but it can be modified easily to add the green highlighting. Although this template followed the HTMLCov design, I thought I would add one that matches the Coveralls.io report style as well. Additionally, it should be easy enough to adjust the config to allow for fully custom templates if one desires.

I was rushing this change out so we could use it in-house; it looks like I missed the warnings. I'll clean up the code. It will be a couple days before I can get back to it though😀

- updated mock lib to allow for context in mocked tests
@erikreedstrom
Copy link
Contributor Author

  • rebased on upstream/master
  • removed code causing warnings
  • added highlights for covered lines
  • added ability for custom template path to be declared

The custom templates could use some work, but it at least provides the ability, even if not in an elegant way 😜

parroty added a commit that referenced this pull request Feb 20, 2016
@parroty parroty merged commit 31564c8 into parroty:master Feb 20, 2016
@parroty
Copy link
Owner

parroty commented Feb 20, 2016

Thanks, great ones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants