Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for minimum coverage #45

Merged
merged 9 commits into from
Apr 6, 2016
Merged

Add support for minimum coverage #45

merged 9 commits into from
Apr 6, 2016

Conversation

campezzi
Copy link
Contributor

This pull request adds support for a new option in the coveralls.json file inside the coverage_options key: minimum_coverage (defaults to zero). When the user adds a value in this option, running mix coveralls or mix coveralls.html will exit with a status code of 1 if total coverage falls below that threshold. This is useful for stopping CI pipelines with tight coverage requirements.

I noticed the Html module had some totalization of stats in it, so those were moved into Stats. That has significantly cleaned up Html. There are many calculations for individual files still going on in the Local module, but I chose not to refactor those for now. We could tackle that on a later PR.

Let me know what you think! Cheers.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 91.103% when pulling c2467b9 on campezzi:master into 05b4c1a on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 91.103% when pulling b318ac3 on campezzi:master into 05b4c1a on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 91.135% when pulling 0d89335 on campezzi:master into 05b4c1a on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 91.135% when pulling eb11fce on campezzi:master into 05b4c1a on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 91.135% when pulling 0a54cd7 on campezzi:master into 05b4c1a on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 91.135% when pulling 090c960 on campezzi:master into 05b4c1a on parroty:master.

@parroty parroty merged commit 10176a7 into parroty:master Apr 6, 2016
@parroty
Copy link
Owner

parroty commented Apr 6, 2016

Thanks for the extensive enhancement and refactoring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants