Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allowedClientClasses. #1853

Closed
wants to merge 1 commit into from
Closed

Added allowedClientClasses. #1853

wants to merge 1 commit into from

Conversation

rob-64
Copy link

@rob-64 rob-64 commented May 20, 2016

Added allowedClientClasses array to allow a client to make a limited set of classes when allowClientClassCreation is false.

@codecov-io
Copy link

codecov-io commented May 20, 2016

Current coverage is 92.01%

Merging #1853 into master will increase coverage by <.01%

@@             master      #1853   diff @@
==========================================
  Files            91         91          
  Lines          6363       6367     +4   
  Methods        1096       1096          
  Messages          0          0          
  Branches       1332       1335     +3   
==========================================
+ Hits           5854       5858     +4   
  Misses          509        509          
  Partials          0          0          

Powered by Codecov. Last updated by b218368...349a818

@rob-64 rob-64 closed this May 20, 2016
@rob-64 rob-64 reopened this May 20, 2016
@drew-gross
Copy link
Contributor

I think the allowClientClassCreation setting covers this feature fairly well. In prod you can ensure the correct classes exist through the dashboard, then set allowClientClassCreation to false and then this new setting is unnecessary. Did you have some specific use case in mind that isn't covered by allowClientClassCreation?

@rob-64
Copy link
Author

rob-64 commented May 20, 2016

@drew-gross, I was trying to limit a malicious user from creating classes/data outside of the scope of my application. I actually had not thought of using the dashboard to setup non system classes before hand. I am fine with doing that and closing request.

@drew-gross
Copy link
Contributor

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants