Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npmignore #318

Merged
merged 1 commit into from
Feb 10, 2016
Merged

Add npmignore #318

merged 1 commit into from
Feb 10, 2016

Conversation

wangmengyan95
Copy link
Contributor

For local dev, if we under parse-sever-example and run npm install, the compiled lib folder for parse-sever will not be moved to parse-server-example/node_modules/parse-server. This is because we have lib in gitignore. Adding npmignore will allow npm to move the lib folder when we do local development. Not sure it is the best way to solve the problem. Feel free to abandon it for better solutions.

@drew-gross
Copy link
Contributor

Even though I also develop under parse-server-example I also feel this is a little janky. Maybe it would be better to have an "official" local development instantiation of the server in the parse-server repo. We could maybe even add an npm develop command or something like that. Thoughts?

@gnz00
Copy link

gnz00 commented Feb 9, 2016

I think this is the canonical way. Npm defaults to gitignore if there is no
npmignore. The gitignore should ignore lib and our npmignore should ignore src.

On Tuesday, February 9, 2016, Drew notifications@github.com wrote:

Even though I also develop under parse-server-example I also feel this is
a little janky. Maybe it would be better to have an "official" local
development instantiation of the server in the parse-server repo. We
could maybe even add an npm develop command or something like that.
Thoughts?


Reply to this email directly or view it on GitHub
#318 (comment)
.

@nlutsenko
Copy link
Contributor

Agreed with the fact that this is a canonical way, we probably also should ignore spec and src in it, so we don't deploy tests and non-compiled source via npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants