Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue stuck sending #3808

Merged
merged 4 commits into from
May 12, 2017
Merged

Fix issue stuck sending #3808

merged 4 commits into from
May 12, 2017

Conversation

flovilmart
Copy link
Contributor

No description provided.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov
Copy link

codecov bot commented May 12, 2017

Codecov Report

Merging #3808 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3808      +/-   ##
==========================================
+ Coverage   90.13%   90.13%   +<.01%     
==========================================
  Files         114      114              
  Lines        7549     7553       +4     
==========================================
+ Hits         6804     6808       +4     
  Misses        745      745
Impacted Files Coverage Δ
src/Push/PushQueue.js 96.55% <100%> (+0.55%) ⬆️
src/Controllers/SchemaController.js 97.04% <0%> (-0.25%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.44% <0%> (ø) ⬆️
src/Adapters/Auth/meetup.js 89.47% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c5d91...90cbe42. Read the comment docs.

@flovilmart flovilmart merged commit 88de01f into master May 12, 2017
@flovilmart flovilmart deleted the fix-issue-stuck-sending branch May 12, 2017 18:24
@@ -27,7 +28,10 @@ export class PushQueue {
// Order by badge (because the payload is badge dependant)
// and createdAt to fix the order
const order = isPushIncrementing(body) ? 'badge,createdAt' : 'createdAt';

where = deepcopy(where);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants