Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for JS SDK nearsphere convenience methods #4827

Closed
wants to merge 2 commits into from
Closed

add tests for JS SDK nearsphere convenience methods #4827

wants to merge 2 commits into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jun 12, 2018

Adding tests for JS SDK nearsphere convenience methods in parse-community/Parse-SDK-JS#582

@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #4827 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   92.71%   92.71%   -0.01%     
==========================================
  Files         119      119              
  Lines        8722     8688      -34     
==========================================
- Hits         8087     8055      -32     
+ Misses        635      633       -2
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoTransform.js 86.83% <0%> (-0.3%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.24% <0%> (+0.04%) ⬆️
src/RestWrite.js 93.79% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e29d02...3f6576a. Read the comment docs.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 12, 2018

This will fail until parse-community/Parse-SDK-JS#582 is merged.

@mtrezza mtrezza changed the title add support for JS SDK nearsphere convenience methods add tests for JS SDK nearsphere convenience methods Jun 12, 2018
@dplewis
Copy link
Member

dplewis commented Jun 28, 2018

Should we close this?

@flovilmart
Copy link
Contributor

Looks like it, i’ll let @mtrezza do it .)

@mtrezza
Copy link
Member Author

mtrezza commented Jun 28, 2018

Done, not needed anyone as integration tests are in JS SDK.

@mtrezza mtrezza closed this Jun 28, 2018
@mtrezza mtrezza deleted the add_support_jssdk_nearsphere_convenience_methods branch July 17, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants