Validates permission before calling beforeSave trigger #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acinader
reviewed
Apr 30, 2019
| @@ -220,6 +220,34 @@ RestWrite.prototype.runBeforeSaveTrigger = function() { | |||
| } | |||
|
|
|||
| return Promise.resolve() | |||
| .then(() => { | |||
| let databasePromise = null; | |||
There was a problem hiding this comment.
can you add a comment here, please.
| @@ -831,13 +849,19 @@ class DatabaseController { | |||
| .then(schema => { | |||
| transformAuthData(className, object, schema); | |||
| flattenUpdateOperatorsForCreate(object); | |||
| if (validateOnly) { | |||
| return object; | |||
There was a problem hiding this comment.
what is getting returned here?
There was a problem hiding this comment.
The original object that would go to the database but in the case of validateOnly, it is just returned after the validations.
| @@ -588,6 +602,9 @@ class DatabaseController { | |||
| 'Object not found.' | |||
| ); | |||
| } | |||
| if (validateOnly) { | |||
| return result; | |||
There was a problem hiding this comment.
what will result be in a validateOnly case?
There was a problem hiding this comment.
In both cases (create and update), it is returning the original object.
acinader
approved these changes
May 11, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…ty#5546) * Test to reproduce the problem * Validating update before calling beforeSave trigger * Fixing lint * Commenting code * Improving the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #5513