Don't trigger beforeSave when logging in with a provider #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me... 👍 |
gfosco
added a commit
that referenced
this pull request
Feb 29, 2016
Don't trigger beforeSave when logging in with a provider
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently beforeSave is called while logging in with a provider such as facebook which feels strange as the user is never modified. It is also a difference from
api.parse.com. Logging in with a provider sends a create request which currently is short circuited in RestWrite.js if the user has already signed up. This PR moves that short circuiting code before the triggering of the beforeSave which means it will no longer be called on logins. More info can be found in #623. I closed that PR as I thought the issue was fixed, but turns out I was wrong. Also added a test for it in this PR.