-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow modify object key without addField permission #7372
Conversation
Generated by 🚫 dangerJS |
Thanks for this PR! Can you please rebase on master to make a tests pass? |
Codecov Report
@@ Coverage Diff @@
## master #7372 +/- ##
==========================================
- Coverage 93.91% 93.90% -0.01%
==========================================
Files 181 181
Lines 13195 13195
==========================================
- Hits 12392 12391 -1
- Misses 803 804 +1
Continue to review full report at Codecov.
|
Also added a corresponding regression test
|
@mtrezza What is the status of this? It would be amazing to get this in ASAP. |
@mstniy could you bring this up-to-date with the alpha branch? |
@mtrezza Would it work if I did it? |
@bdevore17 great, i'll take a look |
New Pull Request Checklist
Issue Description
Modification on nested documents currently require the addField permission.
Related issue: closes #7371
Approach
DatabaseController checks that the root field exists, so if, e.g., the field
a
exists, a modification on the embedded keya.b
will not be considered to be creating a new field.TODOs before merging