S3 Improvements #738
Merged
S3 Improvements #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flovilmart updated the pull request. |
This was referenced Mar 1, 2016
|
Looks good! Can we move towards making this an external repo? Then |
|
I wrote the test to make it easier to move to another repo. We should merge that, first, then move all adapters to 3rd party repos. @gfosco had some thoughts on that too |
| var location = this.adapter.getFileLocation(config, filename); | ||
| return this.adapter.createFile(config, filename, data).then(() => { | ||
| return this.adapter.createFile(config, filename, data, contentType).then(() => { |
There was a problem hiding this comment.
Since this is sort of breaking - can we add this to the docs on FilesAdapter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #731 and #628