Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add TestCustomObjectId.spec.js error #9136

Closed
wants to merge 4 commits into from

Conversation

badboy-tian
Copy link

Pull Request

Issue

#9134
Closes: #9134

Approach

Add TestCustomObjectId.spec.js, test custom objectId. result: object not found

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

Thanks for opening this pull request!

@badboy-tian badboy-tian changed the title Add TestCustomObjectId.spec.js error test: Add TestCustomObjectId.spec.js error May 28, 2024
package.json Outdated
@@ -46,6 +46,7 @@
"lodash": "4.17.21",
"lru-cache": "10.1.0",
"mime": "3.0.0",
"moment": "^2.30.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this dependency

@@ -0,0 +1,59 @@
'use strict';
Copy link
Member

@mtrezza mtrezza May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this test to an existing test file if tests for custom obj ID already exist. And run only this test with fit(...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom objectId not working
2 participants