Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure as a library #1000

Merged
merged 16 commits into from
Nov 27, 2024
Merged

refactor: restructure as a library #1000

merged 16 commits into from
Nov 27, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Nov 21, 2024

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh force-pushed the lib branch 2 times, most recently from d2c8ab6 to 6f154b4 Compare November 25, 2024 07:28
@de-sh de-sh marked this pull request as ready for review November 25, 2024 09:35
@de-sh de-sh requested a review from parmesant November 25, 2024 09:35
@de-sh
Copy link
Contributor Author

de-sh commented Nov 25, 2024

The codepath being pointed out by Deepsource is generated and can be ignored

Copy link
Contributor

github-actions bot commented Nov 26, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nitisht nitisht merged commit fad6b4b into parseablehq:main Nov 27, 2024
8 checks passed
@de-sh de-sh deleted the lib branch November 28, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants