refactor: log ~> tracing
#1013
Merged
refactor: log ~> tracing
#1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
pushed a commit
that referenced
this pull request
Dec 2, 2024
Fixes ci issues pointed out in #1013. This is pertaining to lints which have been introduced in the latest version of clippy.
Signed-off-by: Devdutt Shenoi <devdutt@parseable.com>
parmesant
approved these changes
Dec 9, 2024
de-sh
added a commit
to de-sh/parseable
that referenced
this pull request
Dec 20, 2024
nitisht
pushed a commit
that referenced
this pull request
Dec 20, 2024
…nd sync steps (#1039) * refactor: `log` ~> `tracing` (#1013) Using tracing will allow us to capture span related info in addition to the event based context that we already capture --------- Signed-off-by: Devdutt Shenoi <devdutt@parseable.com> * note span creation and deletion * trace: log steps of ingest and sync --------- Signed-off-by: Devdutt Shenoi <devdutt@parseable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Using tracing will allow us to capture span related info in addition to the event based context that we already capture
Description
This PR has: