Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert all number data types to float #1027

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

nikhilsinhaparseable
Copy link
Contributor

server checks if event has any number (all ints and floats)
then update the data type of all numbers to Float64

src/event/format/json.rs Outdated Show resolved Hide resolved
src/event/format/mod.rs Outdated Show resolved Hide resolved
src/event/format/mod.rs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12276648166

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 46 of 76 (60.53%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 9.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/event/format/json.rs 1 2 50.0%
src/catalog/column.rs 0 5 0.0%
src/metadata.rs 0 12 0.0%
src/storage/object_storage.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
src/event/format/json.rs 1 67.59%
Totals Coverage Status
Change from base Build 12256482714: 0.06%
Covered Lines: 1887
Relevant Lines: 19030

💛 - Coveralls

src/event/format/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Devdutt Shenoi <devdutt@outlook.in>
Signed-off-by: Nitish Tiwari <nitish@parseable.com>
@nitisht nitisht merged commit 6d3632a into parseablehq:main Dec 11, 2024
6 checks passed
nitisht added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants