Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default role api #517

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Add default role api #517

merged 3 commits into from
Sep 27, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Sep 26, 2023

Fixes #513

Description

  • Adds default role in metadata
  • Adds global static for default role
  • Adds endpoint for GET, PUT on default role

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht marked this pull request as ready for review September 27, 2023 09:52
@nitisht nitisht self-requested a review September 27, 2023 09:52
@nitisht nitisht merged commit 1a1c340 into parseablehq:main Sep 27, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@trueleo trueleo deleted the default_role branch October 2, 2023 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default role for new oidc user
2 participants
@trueleo @nitisht