Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch ui version from Cargo toml #518

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Sep 26, 2023

Fixes #515 .

Description

Add uiVersion to about handler response. This value is exported at build time.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 1bbdf89 into parseablehq:main Sep 26, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
@trueleo trueleo deleted the ui_commit branch October 2, 2023 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add console version details in about api
2 participants