Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric layer to s3 store #527

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Add metric layer to s3 store #527

merged 3 commits into from
Oct 4, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 4, 2023 •
edited
Loading

Description

Adds a metric layer over object store implementation

Todo

  • Refactoring
  • Add this to local mode?

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht marked this pull request as ready for review October 4, 2023 12:24
@nitisht nitisht merged commit 24be36f into parseablehq:main Oct 4, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
@trueleo trueleo deleted the object_store_metrics branch October 5, 2023 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueleo @nitisht