added a stream init time field #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo tests are passing, but should test once during runtime to cover any edge cases
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
nitisht
added a commit
to parseablehq/.github
that referenced
this pull request
Dec 30, 2023
nitisht
reviewed
Jan 5, 2024
| .get_whole_json(&stream_name) | ||
| .await | ||
| .unwrap()["created-at"]; | ||
|
|
There was a problem hiding this comment.
We shouldn't have to get this from object store every time. There is an in-memory map maintained at Parseable server to avoid this exact same situation. Please use the map.
There was a problem hiding this comment.
resolved it in the latest commit .... now the created at data is loaded from the file either on load or once the file is created
|
@giripriyadarshan there are some more issues with the PR. We can discuss on Slack. Closing this one for now, in favor of #632 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587 .
Description
adds a feature requested
as it is part of the stream's metadata, this was the only approach I thought of
adds a stream_init_time field to LogStreamMetadata struct. the field is initialized with current epoch time
This PR has: