Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tonic feature add 'tls' #622

Merged
merged 5 commits into from
Jan 13, 2024
Merged

tonic feature add 'tls' #622

merged 5 commits into from
Jan 13, 2024

Conversation

Eshanatnight
Copy link
Contributor

Fixes #608 .

Description

Uses the tls feature of tonic crate.
Read the certificate and key files from CONFIG and add tls_config to server.

Falls back on insecure connection if the certificate and or key is missing.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 76cd676 into parseablehq:main Jan 13, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
@Eshanatnight Eshanatnight deleted the dev branch January 15, 2024 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: TLS for gRPC / live tail connection
2 participants
@Eshanatnight @nitisht