Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #651: removed use of env var P_STORAGE_UPLOAD_INTERVAL #653

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

nikhilsinhaparseable
Copy link
Contributor

fix for #651: removed use of env var P_STORAGE_UPLOAD_INTERVAL
added const of 60 secs to be used for local to storage sync

Fixes: #651

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

…RVAL

added const of 60 secs to be used for local to storage sync
Copy link
Contributor

@Eshanatnight Eshanatnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit fb3fd21 into parseablehq:main Feb 7, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate P_STORAGE_UPLOAD_INTERVAL
3 participants