-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Until to exclude terminator from ParseGraph #360
Milestone
Comments
jvdb
added a commit
that referenced
this issue
Feb 23, 2023
…hout adding the terminator to the ParseGraph. Co-Authored-By: Marja van Aken <marja@infix.ai>
jvdb
changed the title
Extend Until to exclude terminator from parsergraph
Extend Until to exclude terminator from ParseGraph
Feb 23, 2023
jvdb
added a commit
that referenced
this issue
Feb 23, 2023
…constructur. Co-Authored-By: Marja van Aken <marja@infix.ai>
jvdb
added a commit
that referenced
this issue
Feb 24, 2023
Co-Authored-By: Marja van Aken <marja@infix.ai>
mvanaken
added a commit
that referenced
this issue
Mar 1, 2023
mvanaken
added a commit
that referenced
this issue
Mar 2, 2023
This clearly shows the difference in parseGraph between the two variants. Co-authored-by: jvdb <jeroen@infix.ai>
mvanaken
added a commit
that referenced
this issue
Mar 2, 2023
Adjusted the test accordingly. The difference shows that we parse the terminator twice and it has the same name. Co-authored-by: jvdb <jeroen@infix.ai>
mvanaken
added a commit
that referenced
this issue
Mar 2, 2023
#360: Add variant to Until to allow parsing excluding terminator
mvanaken
added a commit
that referenced
this issue
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are three scenarios where you would like to use Until:
The current implementation of Until parses two structures: a def and the terminator.
The current implementation can handle 1. correctly, but for 2 and 3 requires some hacky solutions with some drawbacks. See examples solutions below.
Especially for scenario 3, the "T" part is parsed twice and is also available twice in the parseGraph.
This can be resolved by allowing two implementations of Until where you can specify if the terminator should be part of the parseGraph.
The text was updated successfully, but these errors were encountered: