Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Until: the name does not contain the scope. #367

Closed
mvanaken opened this issue Mar 1, 2023 · 0 comments · Fixed by #368
Closed

Bug in Until: the name does not contain the scope. #367

mvanaken opened this issue Mar 1, 2023 · 0 comments · Fixed by #368
Milestone

Comments

@mvanaken
Copy link
Contributor

mvanaken commented Mar 1, 2023

The resulting def of an Until will recieve the exact name without the names of the parent tokens.

E.g.:

seq("struct", 
    until("value", terminator), 
    def("afterValue", con(1))
);

The name of until is value, while it should be struct.value. The def gets the correct name struct.afterValue.

The problem now is that you are unable to select these values specifically if you are only interested in a value within in named structure.

The fix is simple: the ParseValue in until should use environment.scope instead of name

mvanaken added a commit that referenced this issue Mar 2, 2023
#367 Use scope of environment for ParseValue in Until instead of the direct name.
@mvanaken mvanaken added this to the 10.0.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant