-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add constant derivative boundary condition and expose
GenericBC (#884)
* Change CellV* to V* * Make boundary communication fail if non-cell centered variables have FillGhost or WithFluxes * Remove cc * Rename namespace cell_centered_bvars to var_boundary_comm and fix error * Remove cc from bvals_cc_in_one * Format and lint * Update changelog * Add multipointer * Allow for arbitrary changes of ParArrayND rank and move all array to ParArrayND * Fix particle indexing * Simple sparse pack based interface for face, edge and node variables * Format and lint * Update copyright * update year * Allow for variables w/o topology metadata in packs * Allow ParArrayGeneric::Get to take pairs as args * Remove extraneous ParArray types * Forgot to add new header to CMake * Actually add array to tuple * cleanup, format, and lint * Allow for packing other topological types * Add small test of packing face variables * format and lint * Update changelog * try to fix HIP error and small change * Act on brryan's comments * Small * Format and lint * Update domain functions to deal with varying topological elements * Add Indexer class template * Use Indexer for buffer packing * Start rewriting index calculations * Remove GetTensor stuff * Comment on chosen numbering * Add some comments * Update sparse pack interface to take topological elements * Switch to multiple indexers and format * Remove var_boundary_com namespace * Start switching to new indexing * working for sparse advection * Replace buffer index calculation routines and generalize * In theory should communication should work now for all field types * Avoid duplication * Actually set the number of topological elements for a buffer * Update buffer size calculation * Small * Fix out of range error * Change internal storage so that we don't trigger HtoD * Fix bug in assertion * Switch to std::array since that seems to give no complaints on device * Remove explicit indices from BndInfo * Remove defaulted functions * Switch to enum for choosing boundaries * Add template option for ghost restriction range * Switch to separate indexers for prolongation and restriction * higher precision error output * Stop using RestrictGhostHalos * Remove RestrictGhostHalos * Remove BoundaryType::restricted * Switch to prolongation in one * Format and lint * Remove old boundary prolongation machinery * A temporary fix for MPI runs * format and lint * Use indexers directly * Fix device compilation errors * Format and lint * fix typo * Add generalized volume function * Add function for recovering generic central positions * Generalize restriction * Still working... * Still passing... * Generalize shared restriction * Generalize prolongation and restriction registration to work for all topological types * Index indexers correctly * add element index * Base routine for doing general internal prolongation * Move submanifold routine and add routines to check if operations are required * Add OperationRequired checks to tests * Add all possible cell element types * Remove error causing loop * Only select submanifolds, not the current manifold * Add internal prolongation calls * format and lint * format and lint... * Add internal prolongation, part 2 * fix debug issue * Add some clarifying comments * Switch to using loop indexers required for internal prolongation * Add some comments and a diagram * small * Fix indexing bug when switching to new indexing * Add debug requirement suggested by brryan * fix bug * Move metadata constructor to cpp file * Rename topological elements * format and lint * Rename and catch some bugs * format and lint * Only update cell variables * Remove cell boundary communication checks * fix sparse pack bug for face and edge fields * format and lint * format and lint * Fix indexing bugs * Fill boundary arrays correctly for face and edge variables * Remove weird merge duplication * format and lint * Generalize boundary conditions to non-cell centered fields * Revert sparse pack with fluxes behavior * Format and lint * Rename refinement ops * update changelog * Initialize size_ to zero * respond to comments * Correctly fill vector components * Remove unused dims_ * Switch to sparse packs for GenericBoundary conditions * Add constant derivative BC and move GenericBCs to a new header * Format and lint * update changelog * Add fixed value boundary condition * MeshData boundary conditions * Update to new spase pack interface
- Loading branch information
1 parent
069377b
commit 40dd596
Showing
7 changed files
with
169 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| //======================================================================================== | ||
| // (C) (or copyright) 2020-2022. Triad National Security, LLC. All rights reserved. | ||
| // | ||
| // This program was produced under U.S. Government contract 89233218CNA000001 for Los | ||
| // Alamos National Laboratory (LANL), which is operated by Triad National Security, LLC | ||
| // for the U.S. Department of Energy/National Nuclear Security Administration. All rights | ||
| // in the program are reserved by Triad National Security, LLC, and the U.S. Department | ||
| // of Energy/National Nuclear Security Administration. The Government is granted for | ||
| // itself and others acting on its behalf a nonexclusive, paid-up, irrevocable worldwide | ||
| // license in this material to reproduce, prepare derivative works, distribute copies to | ||
| // the public, perform publicly and display publicly, and to permit others to do so. | ||
| //======================================================================================== | ||
|
|
||
| #ifndef BVALS_BOUNDARY_CONDITIONS_GENERIC_HPP_ | ||
| #define BVALS_BOUNDARY_CONDITIONS_GENERIC_HPP_ | ||
|
|
||
| #include <functional> | ||
| #include <memory> | ||
| #include <set> | ||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "basic_types.hpp" | ||
| #include "interface/meshblock_data.hpp" | ||
| #include "interface/sparse_pack.hpp" | ||
| #include "mesh/domain.hpp" | ||
| #include "mesh/mesh.hpp" | ||
| #include "mesh/meshblock.hpp" | ||
|
|
||
| namespace parthenon { | ||
| namespace BoundaryFunction { | ||
|
|
||
| enum class BCSide { Inner, Outer }; | ||
| enum class BCType { Outflow, Reflect, ConstantDeriv, Fixed }; | ||
|
|
||
| template <CoordinateDirection DIR, BCSide SIDE, BCType TYPE, class... var_ts> | ||
| void GenericBC(std::shared_ptr<MeshBlockData<Real>> &rc, bool coarse, | ||
| TopologicalElement el, Real val) { | ||
| // make sure DIR is X[123]DIR so we don't have to check again | ||
| static_assert(DIR == X1DIR || DIR == X2DIR || DIR == X3DIR, "DIR must be X[123]DIR"); | ||
|
|
||
| // convenient shorthands | ||
| constexpr bool X1 = (DIR == X1DIR); | ||
| constexpr bool X2 = (DIR == X2DIR); | ||
| constexpr bool X3 = (DIR == X3DIR); | ||
| constexpr bool INNER = (SIDE == BCSide::Inner); | ||
|
|
||
| std::vector<MetadataFlag> flags{Metadata::FillGhost}; | ||
| if (GetTopologicalType(el) == TopologicalType::Cell) flags.push_back(Metadata::Cell); | ||
| if (GetTopologicalType(el) == TopologicalType::Face) flags.push_back(Metadata::Face); | ||
| if (GetTopologicalType(el) == TopologicalType::Edge) flags.push_back(Metadata::Edge); | ||
| if (GetTopologicalType(el) == TopologicalType::Node) flags.push_back(Metadata::Node); | ||
|
|
||
| std::set<PDOpt> opts; | ||
| if (coarse) opts = {PDOpt::Coarse}; | ||
| auto desc = MakePackDescriptor<var_ts...>( | ||
| rc->GetBlockPointer()->pmy_mesh->resolved_packages.get(), flags, opts); | ||
| auto q = desc.GetPack(rc.get()); | ||
| const int b = 0; | ||
| const int lstart = q.GetLowerBoundHost(b); | ||
| const int lend = q.GetUpperBoundHost(b); | ||
| if (lend < lstart) return; | ||
| auto nb = IndexRange{lstart, lend}; | ||
|
|
||
| std::shared_ptr<MeshBlock> pmb = rc->GetBlockPointer(); | ||
| const auto &bounds = coarse ? pmb->c_cellbounds : pmb->cellbounds; | ||
|
|
||
| const auto &range = X1 ? bounds.GetBoundsI(IndexDomain::interior, el) | ||
| : (X2 ? bounds.GetBoundsJ(IndexDomain::interior, el) | ||
| : bounds.GetBoundsK(IndexDomain::interior, el)); | ||
| const int ref = INNER ? range.s : range.e; | ||
|
|
||
| std::string label = (TYPE == BCType::Reflect ? "Reflect" : "Outflow"); | ||
| label += (INNER ? "Inner" : "Outer"); | ||
| label += "X" + std::to_string(DIR); | ||
|
|
||
| constexpr IndexDomain domain = | ||
| INNER ? (X1 ? IndexDomain::inner_x1 | ||
| : (X2 ? IndexDomain::inner_x2 : IndexDomain::inner_x3)) | ||
| : (X1 ? IndexDomain::outer_x1 | ||
| : (X2 ? IndexDomain::outer_x2 : IndexDomain::outer_x3)); | ||
|
|
||
| // used for reflections | ||
| const int offset = 2 * ref + (INNER ? -1 : 1); | ||
|
|
||
| // used for derivatives | ||
| const int offsetin = INNER; | ||
| const int offsetout = !INNER; | ||
| pmb->par_for_bndry( | ||
| label, nb, domain, el, coarse, | ||
| KOKKOS_LAMBDA(const int &l, const int &k, const int &j, const int &i) { | ||
| if (TYPE == BCType::Reflect) { | ||
| const bool reflect = (q(b, el, l).vector_component == DIR); | ||
| q(b, el, l, k, j, i) = | ||
| (reflect ? -1.0 : 1.0) * | ||
| q(b, el, l, X3 ? offset - k : k, X2 ? offset - j : j, X1 ? offset - i : i); | ||
| } else if (TYPE == BCType::ConstantDeriv) { | ||
| Real dq = q(b, el, l, X3 ? ref + offsetin : k, X2 ? ref + offsetin : j, | ||
| X1 ? ref + offsetin : i) - | ||
| q(b, el, l, X3 ? ref - offsetout : k, X2 ? ref - offsetout : j, | ||
| X1 ? ref - offsetout : i); | ||
| Real delta = 0.0; | ||
| if (X1) { | ||
| delta = i - ref; | ||
| } else if (X2) { | ||
| delta = j - ref; | ||
| } else { | ||
| delta = k - ref; | ||
| } | ||
| q(b, el, l, k, j, i) = | ||
| q(b, el, l, X3 ? ref : k, X2 ? ref : j, X1 ? ref : i) + delta * dq; | ||
| } else if (TYPE == BCType::Fixed) { | ||
| q(b, el, l, k, j, i) = val; | ||
| } else { | ||
| q(b, el, l, k, j, i) = q(b, el, l, X3 ? ref : k, X2 ? ref : j, X1 ? ref : i); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| template <CoordinateDirection DIR, BCSide SIDE, BCType TYPE, class... var_ts> | ||
| void GenericBC(std::shared_ptr<MeshBlockData<Real>> &rc, bool coarse, Real val = 0.0) { | ||
| using TE = TopologicalElement; | ||
| for (auto el : {TE::CC, TE::F1, TE::F2, TE::F3, TE::E1, TE::E2, TE::E3, TE::NN}) | ||
| GenericBC<DIR, SIDE, TYPE, var_ts...>(rc, coarse, el, val); | ||
| } | ||
|
|
||
| } // namespace BoundaryFunction | ||
| } // namespace parthenon | ||
|
|
||
| #endif // BVALS_BOUNDARY_CONDITIONS_GENERIC_HPP_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters