-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parameter modification from an input file for restarts #1004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but we should probably check this machinery all works nicely somehow... maybe with the restart regression test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we warn the user if CLI and an input file try to override the same parameter in ParameterInput
?
As discussed during the last sync, this would require quite a bit of additional machinery so we'll not warn (for now). |
done |
…on-hpc-lab#1004) * Allow parameter modification from an input file for restarts * Fix typos * Test override from input for restart * Fix path to restart override
PR Summary
What is says on the label quality of life improvement.
Our use case is that we use Parthenon for post-processing and thus need to pass (significant amounts) of new parameters, e.g., for histograms which gets hard to manage (and some even hit a limit in terms of what the bash allows).
PR Checklist