Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameter modification from an input file for restarts #1004

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Feb 2, 2024

PR Summary

What is says on the label quality of life improvement.
Our use case is that we use Parthenon for post-processing and thus need to pass (significant amounts) of new parameters, e.g., for histograms which gets hard to manage (and some even hit a limit in terms of what the bash allows).

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pgrete pgrete added the enhancement New feature or request label Feb 2, 2024
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but we should probably check this machinery all works nicely somehow... maybe with the restart regression test?

Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/sphinx/src/README.rst Outdated Show resolved Hide resolved
doc/sphinx/src/outputs.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we warn the user if CLI and an input file try to override the same parameter in ParameterInput?

doc/sphinx/src/README.rst Outdated Show resolved Hide resolved
@pgrete
Copy link
Collaborator Author

pgrete commented Apr 10, 2024

Should we warn the user if CLI and an input file try to override the same parameter in ParameterInput?

As discussed during the last sync, this would require quite a bit of additional machinery so we'll not warn (for now).

@pgrete
Copy link
Collaborator Author

pgrete commented Apr 10, 2024

This looks fine, but we should probably check this machinery all works nicely somehow... maybe with the restart regression test?

done

@pgrete pgrete enabled auto-merge (squash) April 10, 2024 08:53
@pgrete pgrete disabled auto-merge April 10, 2024 10:25
@pgrete pgrete enabled auto-merge (squash) April 10, 2024 10:25
@pgrete pgrete merged commit ac561f7 into develop Apr 10, 2024
49 checks passed
@pgrete pgrete deleted the pgrete/parse-input-file-when-restarting branch April 10, 2024 11:31
bprather pushed a commit to AFD-Illinois/parthenon that referenced this pull request Jul 17, 2024
…on-hpc-lab#1004)

* Allow parameter modification from an input file for restarts

* Fix typos

* Test override from input for restart

* Fix path to restart override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants