Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly fill VariableFluxPack for edge fluxes in 2D #1083

Merged
merged 7 commits into from
May 23, 2024
Merged

Correctly fill VariableFluxPack for edge fluxes in 2D #1083

merged 7 commits into from
May 23, 2024

Conversation

acreyes
Copy link
Contributor

@acreyes acreyes commented May 21, 2024 •
edited
Loading

PR Summary

  • X3 flux is filled in 2D for Metadata::Faces with Metadata::WithFluxes.

fixes #1082

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur requested a review from lroberts36 May 21, 2024 14:53
Yurlungur
Yurlungur approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a fix! Can you also add this PR to CHANGELOG.md in your fork? I'm clicking approve for the CI to run.

@Yurlungur Yurlungur added the bug Something isn't working label May 21, 2024
@Yurlungur Yurlungur enabled auto-merge May 21, 2024 16:06
@Yurlungur
Copy link
Collaborator

Ping @lroberts36 for second review.

lroberts36
lroberts36 approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching the bug and the nice fix!

@lroberts36 lroberts36 disabled auto-merge May 22, 2024 00:21
@lroberts36 lroberts36 enabled auto-merge May 22, 2024 00:21
@lroberts36 lroberts36 disabled auto-merge May 22, 2024 01:29
@lroberts36 lroberts36 enabled auto-merge May 22, 2024 01:29
@lroberts36 lroberts36 disabled auto-merge May 22, 2024 23:22
@lroberts36 lroberts36 enabled auto-merge May 22, 2024 23:22
@lroberts36 lroberts36 disabled auto-merge May 23, 2024 00:55
@lroberts36 lroberts36 enabled auto-merge May 23, 2024 00:55
@Yurlungur
Copy link
Collaborator

Not sure why this isn't automatically merging. Will force merge.

@Yurlungur Yurlungur disabled auto-merge May 23, 2024 01:20
@Yurlungur Yurlungur merged commit 1d7c700 into parthenon-hpc-lab:develop May 23, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VariableFluxPack for Face fields in 2D
3 participants
@acreyes @Yurlungur @lroberts36