Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small: Refactor setting linear solver parameters #1105

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Small: Refactor setting linear solver parameters #1105

merged 3 commits into from
Jun 20, 2024

Conversation

lroberts36
Copy link
Collaborator

@lroberts36 lroberts36 commented Jun 12, 2024 •
edited
Loading

PR Summary

This PR makes a small change to allow easily reading solver parameters from parameter input without code duplication. Some unused parameters are also removed from the poisson_gmg example.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@lroberts36 lroberts36 requested review from pdmullen, Yurlungur, bprather and jdolence and removed request for pdmullen June 12, 2024 22:33
pdmullen
pdmullen approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yurlungur
Yurlungur approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lroberts36 lroberts36 merged commit 0723f1f into develop Jun 20, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@pdmullen pdmullen pdmullen approved these changes

@bprather bprather Awaiting requested review from bprather

@jdolence jdolence Awaiting requested review from jdolence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lroberts36 @Yurlungur @pdmullen