Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small: Default initialize BndInfo.dir #1121

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Small: Default initialize BndInfo.dir #1121

merged 2 commits into from
Jun 18, 2024

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Jun 18, 2024 •
edited
Loading

PR Summary

Default initializes the value of BndInfo.dir to X0DIR.

This fixes the sanitizer warnings that appear in #1120.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@BenWibking BenWibking changed the title default initialize BndInfo.dir Small: Default initialize BndInfo.dir Jun 18, 2024
lroberts36
lroberts36 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@BenWibking BenWibking merged commit 91fb5b6 into develop Jun 18, 2024
50 checks passed
@BenWibking BenWibking deleted the BenWibking/fix-bnd-info-init branch July 11, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenWibking @Yurlungur @lroberts36