Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cycle and nbtotal to hst #1128

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Add cycle and nbtotal to hst #1128

merged 9 commits into from
Jun 25, 2024

Conversation

pdmullen
Copy link
Collaborator

@pdmullen pdmullen commented Jun 22, 2024

PR Summary

This PR adds the cycle and total number of MeshBlocks to the history file output. If we choose to merge this one, please merge it after #1127.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Two things:

  1. Can you make sure that the isntrucitons for checking correctness in benchmark/burgers still work?
  2. Make sure this only goes in after Add WithFluxes to IsRefined check #1127

@pdmullen
Copy link
Collaborator Author

👍 Two things:

  1. Can you make sure that the isntrucitons for checking correctness in benchmark/burgers still work?
  2. Make sure this only goes in after Add WithFluxes to IsRefined check #1127

Just went through the benchmark/burgers test. It looks like it was shipping its own custom nbtotal reduction. I eliminated this since this data is now outputted to hst by default. The new history files are compatible with the burgers_diff.py script, however, I'd note that this script had a bug in it such that no diffs would ever actually be reported --- fixed now.

@Yurlungur
Copy link
Collaborator

👍 Two things:

  1. Can you make sure that the isntrucitons for checking correctness in benchmark/burgers still work?
  2. Make sure this only goes in after Add WithFluxes to IsRefined check #1127

Just went through the benchmark/burgers test. It looks like it was shipping its own custom nbtotal reduction. I eliminated this since this data is now outputted to hst by default. The new history files are compatible with the burgers_diff.py script, however, I'd note that this script had a bug in it such that no diffs would ever actually be reported --- fixed now.

Thanks @pdmullen !

Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pdmullen pdmullen enabled auto-merge June 25, 2024 00:18
@pdmullen pdmullen disabled auto-merge June 25, 2024 00:23
@pdmullen pdmullen enabled auto-merge June 25, 2024 00:53
@pdmullen pdmullen disabled auto-merge June 25, 2024 01:55
@pdmullen pdmullen enabled auto-merge June 25, 2024 02:02
@pdmullen pdmullen merged commit a44da26 into develop Jun 25, 2024
50 checks passed
@pdmullen pdmullen deleted the pdmullen/hst-nbtotal branch June 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants