[Trivial] Add ability to use system packages #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
requested review from
BenWibking,
bprather,
lroberts36 and
pgrete
Yurlungur
commented
Sep 10, 2024
Comment on lines
+64
to
+72
| if (PARTHENON_USE_SYSTEM_PACKAGES) | ||
| option(PARTHENON_IMPORT_KOKKOS | ||
| "If ON, attempt to link to an external Kokkos library. If OFF, build Kokkos from source and package with Parthenon" | ||
| ON) | ||
| else() | ||
| option(PARTHENON_IMPORT_KOKKOS | ||
| "If ON, attempt to link to an external Kokkos library. If OFF, build Kokkos from source and package with Parthenon" | ||
| OFF) | ||
| endif() |
There was a problem hiding this comment.
I considered using CMakeDependentOption here, but I want IMPORT_KOKKOS available and user-visible no matter which setting of PARTHENON_USE_SYSTEM_PACKAGES was chosen.
lroberts36
approved these changes
Sep 10, 2024
pdmullen
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In issues #1168 and #1169 @yurivict pointed out that the default parthenon configuration is designed for supercomputers where system packages are not used easily. This of course makes sense in our context. However it apparently raises issues for packaging on, e.g., a unix distro.
This MR resolves #1169 by adding the cmake option
PARTHENON_USE_SYSTEM_PACKAGESwhich is set toOFFby default. Enabling this automatically setsPARTHENON_IMPORT_KOKKOStoONand also removes all instances (of which there is currently one) ofNO_DEFAULT_PATHinfind_packagecalls.PR Checklist