Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatter SetBounds #1196

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Flatter SetBounds #1196

wants to merge 13 commits into from

Conversation

bprather
Copy link
Collaborator

@bprather bprather commented Oct 22, 2024

PR Summary

This moves the t, u and v indices of the kernel in SetBounds to the outer loop from their current spot in the inner loop. This will help to launch enough teams via the outer loop in codes with a single variable and single block per rank, where the total number of boundary buffers on a rank may be quite small.

Because all the indices are abstracted, one could imagine using basically this code to instead specify a desired number of teams, or amount of work per team -- the additional flexibility might let a broader range of codes realize a little speedup.

Remaining todo:

  • Add this tweak to SendBoundBufs as well
  • Syntactic sugar to avoid the max(outer_product(Nx...)) shenanigans
  • Potentially allow more flexible tweaking of outer/inner loop size at runtime (possibly integrates with what @pgrete was doing with loop sizes during the hackathon). Probably useful in many/most nested-parallel loops.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@bprather bprather changed the title WIP: Flattened SetBounds WIP: Flatter SetBounds Oct 24, 2024
@bprather bprather changed the title WIP: Flatter SetBounds Flatter SetBounds Oct 31, 2024
@bprather
Copy link
Collaborator Author

@par-hermes format

@pgrete pgrete enabled auto-merge (squash) December 18, 2024 14:13
@pgrete pgrete disabled auto-merge December 18, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants