add precommfillderived #889
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
requested review from
BenWibking,
bprather,
forrestglines,
lroberts36,
pgrete and
pdmullen
Co-authored-by: Patrick Mullen <33095288+pdmullen@users.noreply.github.com>
|
Tests are failing with a segfault for some reason. Will chase it down. |
|
Segfault fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a feature used by riot, that we'd like to bring into the parthenon develop branch, as we push towards bringing riot onto "standard" parthenon.
The basic idea here is that if you want to communicate derived quantities in ghost zones, for example pressure, you need to compute them first. You can do so in the precomm fill derived, which is a separate task the user can call if desired. This may also be interesting for the AthenaPK folks as a way to do pressure or other pimitive-based prolong/restrict if desired.
PR Checklist