Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking change] Add fine field option #991
[Breaking change] Add fine field option #991
Changes from all commits
63a02c4
23bb48c
17cc7a5
96157a8
4f55a57
d6b3b8d
e1c7765
4f85d41
72d298b
88b0265
82d1ab0
bd628c9
bbf64b6
809c002
feba54c
4de848d
8b2bbeb
b99d91f
257ca7b
89851f2
022e7ee
cf58b9d
f0719b6
0b5cf06
b36f0b6
b9885d0
02a964d
8a114d2
d201fa0
e297ef7
cffad7b
a92e0ad
0a04680
9414f43
d58b26e
005311e
363d6a9
3941563
d8a1643
f1308a3
b02b1ef
77aede6
d3be6bb
1ae7285
9e0d019
84c6329
92a5fbf
78e3e34
d525322
d36cf12
55078fc
a2b935d
8caa94c
46cbb5e
22bfe57
247fc59
0f07b70
27d3676
afccac5
a4bedd6
7245148
30d57ee
90ff0dc
8982895
cf28375
7e32ab3
593564d
e439478
50711d6
fdc437e
4362d9d
16bc508
e4a63b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Independent of this PR but relevant in the context of recent discussion around exhausting MPI limits, it might be worth to change the pattern here to first start all receives (in their own
TaskRegion
) rather than starting them "per pack" as the behavior will then depend on the pack size.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that seems reasonable.