Breaks network on-going network connection when Sleep stop mode is called #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeuz
commented
Sep 23, 2016
| #ifndef SPARK_NO_CLOUD | ||
| wakeupState.cloud = spark_cloud_flag_auto_connect(); | ||
| #endif | ||
| wakeupState.wifi = !SPARK_WLAN_SLEEP; | ||
| wakeupState.wifiConnected = wakeupState.cloud || network_ready(0, 0, NULL) || network_connecting(0, 0, NULL); |
There was a problem hiding this comment.
I've noticed that wakeupState.cloud was used before initialization previously.
…ivity; cancel active connection attempt to unblock the system thread
technobly
force-pushed
the
fix/stop_mode_power
branch
from
ba6f212 to
e27362f
Compare
technobly
approved these changes
Oct 17, 2016
technobly
added a commit
that referenced
this pull request
Dec 20, 2016
technobly
added a commit
that referenced
this pull request
Dec 20, 2016
technobly
changed the title
avtolstoy
added a commit
that referenced
this pull request
May 10, 2017
…ivity; cancel active connection attempt to unblock the system thread (see #1125)
avtolstoy
added a commit
to avtolstoy/firmware
that referenced
this pull request
May 10, 2017
…ivity; cancel active connection attempt to unblock the system thread (see particle-iot#1125)
avtolstoy
pushed a commit
to avtolstoy/firmware
that referenced
this pull request
May 10, 2017
…rt-of-1125 Bring back part of particle-iot#1125
sergeuz
pushed a commit
that referenced
this pull request
Jun 4, 2017
…ivity; cancel active connection attempt to unblock the system thread (see #1125)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks network on-going network connection when Sleep stop mode is called, thereby speeding up the time to entering sleep when using SYSTEM_THREAD(ENABLED).
Doneness:
Enhancement