Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance tests for PR #1097 (OTA/YModem update result) #1153

Merged
merged 18 commits into from
Nov 29, 2016
Merged

Acceptance tests for PR #1097 (OTA/YModem update result) #1153

merged 18 commits into from
Nov 29, 2016

Conversation

avtolstoy
Copy link
Member

@avtolstoy avtolstoy commented Oct 30, 2016 •
edited by technobly
Loading

Includes:

To run cucumber tests:

  • $ cd user/tests/accept
  • $ bundler install
  • $ ./run update_result

NOTE: spark/device/ota_result is not whitelisted yet

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (N/A, see OTA/YModem update result #1097)
  • Add to CHANGELOG.md after merging (add links to docs and issues) (N/A, see OTA/YModem update result #1097)

avtolstoy and others added 18 commits October 30, 2016 02:23
@avtolstoy
OTA/YModem update result:
d88001e 
- OTA: "spark/device/ota_result" event
- YModem: ACK/CANCEL + string error code (validation bitmask)
@avtolstoy
Reject received file only when the host has requested to end the session
4d71b9c
@sergeuz
Wiring library: Vector class, JSON tools; unit test helper tools
3dc6f6a
@sergeuz
Make compile-dependency on strtol() and strtod() optional
e4e1a6e
@sergeuz
Minor fix
7d404a8
@sergeuz
Runtime logging configuration; asynchronous USB requests; helper tool…
cbda226 
…s for acceptance testing
@avtolstoy
Allow logging from an ISR when DEBUG_BUILD=y
d81371e
@avtolstoy
Do not use ATOMIC_BLOCK() in spark_wiring_logging.cpp on PLATFORM=3 i…
be9c07a 
…n order for unit tests to pass
@avtolstoy
Merge remote-tracking branch 'origin/feature/usb_logging_1_of_2' into…
8d5663e 
… feature/update-status-2
@avtolstoy
Merge remote-tracking branch 'origin/feature/usb_logging_2_of_2' into…
92ae191 
… feature/update-status-2
@avtolstoy
user/tests/accept: device_ctl support script: renaming 'listen' mode …
b974e17 
…to 'listening'. Adding command to request device id via USB vendor request
@avtolstoy
user/tests/accept: fixing usb PID/VID for Electron and P1
39889fb
@avtolstoy
user/tests/accept: Adding @log_config tag to log_config test suite
05604fc
@avtolstoy
user/tests/accept: update_result test suite for PR #1097
edc219e
@avtolstoy
user/tests/accept: Some OSX fixes
02e4760
@avtolstoy
user/tests/accept: Enter into DFU using USB vendor requests before fl…
c4e7ba3 
…ashing an app
@avtolstoy
usb_hal: Initiate data stage anyway, if vendor request handler return…
6bb3318 
…ed wLength = 0
@avtolstoy
Merge remote-tracking branch 'origin/feature/usb_logging_2_of_2' into…
48987b9 
… feature/update-status-2
@avtolstoy avtolstoy added this to the 0.7.x milestone Nov 7, 2016
@technobly technobly merged commit 9c0ac55 into develop Nov 29, 2016
@technobly technobly deleted the feature/update-status-2 branch November 29, 2016 00:52
@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016
@avtolstoy avtolstoy mentioned this pull request Mar 6, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technobly technobly technobly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@avtolstoy @technobly @sergeuz